Proposal: Vendor mobx-state-tree #4938
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Likely if this PR did 'go through' I'd move the @jbrowse/mobx-state-tree outside of the monorepo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes 'vendoring' mobx-state-tree
The mobx-state-tree repo down-transpiles to es5 classes which are slower, and we can make things somewhat faster as a result of doing less transpiling
As an example, it has the nice effect of a 2x speed improvement on importing (8 seconds -> 3.7s with about 2,000 tracks). The full proper speedup for large tracklists may still be the 'frozen tracks' branch, but this PR is helpful in that regard