Attempt to fix memory leak when side scrolling or skipping at same zoom level #5283
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmdcolin
force-pushed
the
granular_rect_memory
branch
2 times, most recently
from
938cd54 to
8061849
Compare
cmdcolin
force-pushed
the
granular_rect_memory
branch
from
8061849 to
28e1519
Compare
cmdcolin
force-pushed
the
granular_rect_memory
branch
from
1ab5b14 to
e4b6641
Compare
cmdcolin
force-pushed
the
granular_rect_memory
branch
from
e4b6641 to
577e753
Compare
cmdcolin
force-pushed
the
granular_rect_memory
branch
from
577e753 to
22ce6ec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Possible fix for #4844
The layout does not get 'cleaned up' as long as you stay at the same zoom level, and now feature data is stored in the layout which increases it's size
Needs to be tested still but several automated tests were created that pass
It is also possible that there may be multiple memory leaks also with this only being one of them...memory leaks are tricky business compared to most simple debugging tasks so will need investigation