-
Notifications
You must be signed in to change notification settings - Fork 75
Render linear synteny view using webworker #5313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
cmdcolin
wants to merge
24
commits into
main
Choose a base branch
from
refactor_abstract_canvas_renderers
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Fixes #4616 |
Collaborator
Author
|
Example share link using this branch can see the synteny rendering lags a little behind but it doesn't 'feel too bad' from a user experience perspective since the interface stays responsive |
Collaborator
Author
|
marked as draft. will need to incorporate stop tokens and improved synchronization (the renderer should respond with what it rendered to help the main thread confirm that that the rendering is relevant) |
…stract_canvas_renderers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
The LinearSyntenyView renders all the data in the main thread. It downloads all the data to the main thread using CoreGetFeatures and then renders it on every frame.
This PR
This PR changes the rendering to happen in the web worker
It uses transferControlToOffscreen (https://developer.mozilla.org/en-US/docs/Web/API/HTMLCanvasElement/transferControlToOffscreen) to let the webworker draw straight to the main thread's DOM canvas
Caveat
This is currently significantly less 'smooth' on scrolling, but this could probably be worked on further, and the effect of not bogging down the main thread with extremely slow rendering probably is worth it