Skip to content

Export fetchResults from linear-genome-view#5482

Merged
cmdcolin merged 1 commit intoGMOD:mainfrom
hextraza:export-fetch-results
Feb 12, 2026
Merged

Export fetchResults from linear-genome-view#5482
cmdcolin merged 1 commit intoGMOD:mainfrom
hextraza:export-fetch-results

Conversation

@hextraza
Copy link
Copy Markdown
Contributor

Hi,

I'm part of @bbimber's group. As part of responding to #5290, I'm updating our jbrowse-components version to v4.1.3. We have a component here that relies on a deep import from the linear-genome-view plugin like so:

import { fetchResults } from '@jbrowse/plugin-linear-genome-view/esm/LinearGenomeView/components/util';

As I understand it, with the move to ESM, this sort of import is no longer possible. Would it make sense to export fetchResults, and potentially other members of searchUtils.ts?

@cmdcolin
Copy link
Copy Markdown
Collaborator

Hi there
I could potentially merge this but this may be something that changes again in the future. These are sort of internal utilities and the 'public interface' isn't super well thought out and it was only sort of random that the 'deep imports' worked (indeed with esm they do not work any longer)

If that sounds ok lemme know

@cmdcolin
Copy link
Copy Markdown
Collaborator

Just as a random aside, I know the removal of svg was a subject of discussion, and just to bring to your attention, we are doing additional work to potentially adopt webgl. This could affect renderer code yet again #5468

@bbimber
Copy link
Copy Markdown
Contributor

bbimber commented Feb 12, 2026

I appreciate the heads up, and broadly speaking we understand this is less than a formal public API and might be subject to change.

Through the SvgRenderer migration, we were able to remove some of our historic custom code, which has an overall plus.

@cmdcolin
Copy link
Copy Markdown
Collaborator

super :) glad to hear. I'll just go ahead with merge!

@cmdcolin cmdcolin merged commit fe4a9b7 into GMOD:main Feb 12, 2026
cmdcolin added a commit that referenced this pull request Feb 13, 2026
Update

Refactorings

Make each sequence panel in feature details use an independent mobx-state-tree instance (#5478)

Export fetchResults from linear-genome-view (#5482)

Co-authored-by: Sebastian Benjamin <sebastiancbenjamin@gmail.com>

[skip ci] Fix trackname not showing up in search results dialog (#5480)

K1

K2
cmdcolin added a commit that referenced this pull request Feb 13, 2026
Update

Refactorings

Make each sequence panel in feature details use an independent mobx-state-tree instance (#5478)

Export fetchResults from linear-genome-view (#5482)

Co-authored-by: Sebastian Benjamin <sebastiancbenjamin@gmail.com>

[skip ci] Fix trackname not showing up in search results dialog (#5480)

K1

K2
cmdcolin added a commit that referenced this pull request Feb 13, 2026
Update

Refactorings

Make each sequence panel in feature details use an independent mobx-state-tree instance (#5478)

Export fetchResults from linear-genome-view (#5482)

Co-authored-by: Sebastian Benjamin <sebastiancbenjamin@gmail.com>

[skip ci] Fix trackname not showing up in search results dialog (#5480)

K1

K2
@cmdcolin cmdcolin added enhancement New feature or request internal labels Feb 15, 2026
@cmdcolin
Copy link
Copy Markdown
Collaborator

now released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request internal

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants