Export fetchResults from linear-genome-view#5482
Conversation
|
Hi there If that sounds ok lemme know |
|
Just as a random aside, I know the removal of svg was a subject of discussion, and just to bring to your attention, we are doing additional work to potentially adopt webgl. This could affect renderer code yet again #5468 |
|
I appreciate the heads up, and broadly speaking we understand this is less than a formal public API and might be subject to change. Through the SvgRenderer migration, we were able to remove some of our historic custom code, which has an overall plus. |
|
super :) glad to hear. I'll just go ahead with merge! |
Update Refactorings Make each sequence panel in feature details use an independent mobx-state-tree instance (#5478) Export fetchResults from linear-genome-view (#5482) Co-authored-by: Sebastian Benjamin <sebastiancbenjamin@gmail.com> [skip ci] Fix trackname not showing up in search results dialog (#5480) K1 K2
Update Refactorings Make each sequence panel in feature details use an independent mobx-state-tree instance (#5478) Export fetchResults from linear-genome-view (#5482) Co-authored-by: Sebastian Benjamin <sebastiancbenjamin@gmail.com> [skip ci] Fix trackname not showing up in search results dialog (#5480) K1 K2
Update Refactorings Make each sequence panel in feature details use an independent mobx-state-tree instance (#5478) Export fetchResults from linear-genome-view (#5482) Co-authored-by: Sebastian Benjamin <sebastiancbenjamin@gmail.com> [skip ci] Fix trackname not showing up in search results dialog (#5480) K1 K2
|
now released |
Hi,
I'm part of @bbimber's group. As part of responding to #5290, I'm updating our jbrowse-components version to v4.1.3. We have a component here that relies on a deep import from the linear-genome-view plugin like so:
import { fetchResults } from '@jbrowse/plugin-linear-genome-view/esm/LinearGenomeView/components/util';As I understand it, with the move to ESM, this sort of import is no longer possible. Would it make sense to export fetchResults, and potentially other members of
searchUtils.ts?