Implement basic concept for rendering labels on GWAS display#18
Open
Implement basic concept for rendering labels on GWAS display#18
Conversation
Collaborator
Author
|
(also, I just generally apologize that doing things like this is difficult in jbrowse. I wish it was as easy as a ggplot with adding a label layer but currently a lot of manual work...let me know if i can help with any questions) |
|
@cmdcolin Thank you very much for this prototype! I'll try it out soon and share the feedback and updates probably next week. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes an arbitrary cutoff and draws features with score > 30 for demo purposes
I think that a systematic way to determine which feature to render a label on is needed. This should require literature and/or code cross reference to other GWAS libraries
In some cases, you might want to render nearby gene
In some cases you might want to render just the "leading SNP", which gets into the idea of linkage disequilibrium which has not been addressed much
If we have realistic datasets to help with this, it might help
CC @abcdw @pjotrp
Screenshot on demo data
The logic behind this PR is:
The 'renderer' returns a click map, then the click map is propagated to the 'display', and then the display renders 'highScoringFeatures' (with that score>30 cutoff) using HTML text labels that are absolutely positioned. could also use svg text nodes alternatively.