Bug and enhancement for accrual periodicity#89
Open
jbrown-xentity wants to merge 9 commits intomainfrom
Open
Conversation
neilmb
approved these changes
Mar 19, 2026
Collaborator
neilmb
left a comment
There was a problem hiding this comment.
LGTM, one copy-pasta fix, but otherwise great.
| { | ||
| "@type": "Dataset", | ||
| "title": "Example Dataset", | ||
| "description": "A minimal dataset example with invalid periodicity", |
Collaborator
There was a problem hiding this comment.
Comment (non-blocking): This looks like a copy-paste error.
Suggested change
| "description": "A minimal dataset example with invalid periodicity", | |
| "description": "A minimal dataset example with a valid periodicity", |
zopalmer14
reviewed
Mar 19, 2026
zopalmer14
approved these changes
Mar 19, 2026
zopalmer14
left a comment
There was a problem hiding this comment.
Schema changes and examples LGTM. I left one comment on test_json_schema.py but it's trivial
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Plans to resolve #16 and #17, and address comments. This replaces #58, which is out of date and doesn't have some necessary changes/upgrades.
I agree @zopalmer14 , this shouldn't be any string. I've limited it to the lists from the different standards, and linked to the documentation in the JSON schema description. Because ISO-8601 is so open and contains so many possibilities, I decided to allow "recurring" type strings but to allow any number or value type without getting too in the weeds on what could possibly be implemented (months, days, time seconds, etc).
Now that we understand the nuance between
oneOfandanyOf(oneOfforces it to only match one of the possible validations, which is rare that we want to do), this should be good to go.This also provides a good starting point for the "complete" dataset example. It's quite extensive, but also isn't fully complete because it ignores every implementation of the "Concept" class, which is itself a whole issue that should be addressed. I also updated the test code to give more detailed and simplified information around things that don't validate. Below is what it looked like before the improvements, the latter after these changes.
Before updates:
After updates: