Skip to content

Bug and enhancement for accrual periodicity #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jbrown-xentity wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Bug and enhancement for accrual periodicity #89

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
91fdf29
Add updates to dataset.json, using latest information.
jbrown-xentity Mar 19, 2026
1c51268
Good (currently failing) example, to be iterated on.
jbrown-xentity Mar 19, 2026
63a42d9
Provide good and bad example, and update test to provide more detaile…
jbrown-xentity Mar 19, 2026
956785a
Add more clarity for reporting issues with validation for "good" sche…
jbrown-xentity Mar 19, 2026
485ed28
Add good working example of a Dataset. Also fix drive-by periodOfTime…
jbrown-xentity Mar 19, 2026
0f7092d
Formatting
jbrown-xentity Mar 19, 2026
f94aeb3
Integrate dataSeries with this; it should be the same change in this …
jbrown-xentity Mar 19, 2026
565268a
Fix formatting
jbrown-xentity Mar 19, 2026
698e34f
Remove unused function
jbrown-xentity Mar 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion .vscode/settings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,18 @@
{
"todo-tree.tree.scanMode": "current file",
"liveServer.settings.port": 5501
"liveServer.settings.port": 5501,
"json.format.keepLines": true,
"editor.tabSize": 2,
"editor.detectIndentation": false,
"editor.indentSize": "tabSize",
"editor.insertSpaces": false,
"editor.useTabStops": false,
"[json]": {
"editor.insertSpaces": true,
"editor.tabSize": 2,
"editor.formatOnSave": true
},
"js/ts.format.insertSpaceAfterOpeningAndBeforeClosingEmptyBraces": false,
"js/ts.format.insertSpaceAfterOpeningAndBeforeClosingNonemptyBraces": false,
"js/ts.format.insertSpaceBeforeAndAfterBinaryOperators": true,
}
47 changes: 42 additions & 5 deletions jsonschema/definitions/Dataset.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -477,18 +477,55 @@
"accrualPeriodicity": {
"title": "frequency",
"description": "The frequency at which the Dataset is updated",
"oneOf": [
"anyOf": [
{
"type": "null"
},
{
"$ref": "/dcat-us/3.0.0/definitions/frequency",
"description": "inline description of Frequency"
"type": "string",
"description": "ISO 19115 Maintenance Frequency code, see https://infopolicy.github.io/dcat-us/#frequency-coding",
"enum": [
"continual",
"daily",
"weekly",
"fortnightly",
"monthly",
"quarterly",
"biannually",
"annually",
"asNeeded",
"irregular",
"notPlanned",
"unknown"
]
},
{
"type": "string",
"description": "reference iri of Frequency",
"format": "iri"
"description": "ISO-8601 Maintenance Frequency code for recurring values, see https://infopolicy.github.io/dcat-us/#frequency-coding",
"pattern": "^R\/P.+$"
},
{
"type": "string",
"description": "Dublin Core Collection Frequency Vocabulary, see https://infopolicy.github.io/dcat-us/#frequency-coding",
"enum": [
"continuous",
"daily",
"weekly",
"biweekly",
"monthly",
"quarterly",
"semiannual",
"annual",
"irregular",
"triennial",
"biennial",
"threeTimesAYear",
"bimonthly",
"semimonthly",
"threeTimesAMonth",
"semiweekly",
"threeTimesAWeek"
]
}
]
},
Expand Down
47 changes: 42 additions & 5 deletions jsonschema/definitions/DatasetSeries.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,18 +102,55 @@
"accrualPeriodicity": {
"title": "frequency",
"description": "The frequency at which the Dataset Series is updated",
"oneOf": [
"anyOf": [
{
"type": "null"
},
{
"$ref": "/dcat-us/3.0.0/definitions/frequency",
"description": "inline description of Frequency"
"type": "string",
"description": "ISO 19115 Maintenance Frequency code, see https://infopolicy.github.io/dcat-us/#frequency-coding",
"enum": [
"continual",
"daily",
"weekly",
"fortnightly",
"monthly",
"quarterly",
"biannually",
"annually",
"asNeeded",
"irregular",
"notPlanned",
"unknown"
]
},
{
"type": "string",
"description": "reference iri of Frequency",
"format": "iri"
"description": "ISO-8601 Maintenance Frequency code for recurring values, see https://infopolicy.github.io/dcat-us/#frequency-coding",
"pattern": "^R\/P.+$"
},
{
"type": "string",
"description": "Dublin Core Collection Frequency Vocabulary, see https://infopolicy.github.io/dcat-us/#frequency-coding",
"enum": [
"continuous",
"daily",
"weekly",
"biweekly",
"monthly",
"quarterly",
"semiannual",
"annual",
"irregular",
"triennial",
"biennial",
"threeTimesAYear",
"bimonthly",
"semimonthly",
"threeTimesAMonth",
"semiweekly",
"threeTimesAWeek"
]
}
]
},
Expand Down
4 changes: 2 additions & 2 deletions jsonschema/definitions/PeriodOfTime.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
},
{
"type": "string",
"oneOf": [
"anyOf": [
{
"format": "date-time"
},
Expand Down Expand Up @@ -50,7 +50,7 @@
},
{
"type": "string",
"oneOf": [
"anyOf": [
{
"format": "date-time"
},
Expand Down
7 changes: 7 additions & 0 deletions jsonschema/examples/Dataset/bad/bad-accrual-periodicity.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"@type": "Dataset",
"title": "Example Dataset",
"description": "A minimal dataset example with invalid periodicity",
"publisher": "https://example.gov/org/sample-agency",
"accrualPeriodicity": "every-other-tuesday"
}
Loading
Loading