Mui2 tesla tower #5238
Mui2 tesla tower #5238
Conversation
…s create synchandlers instead
FrostyFire1
added
New Feature
FrostyFire1
added
✔️ Tested on Server
chrombread
left a comment
chrombread
left a comment
There was a problem hiding this comment.
some feedback. code makes sense more or less (and the chart widgets might be able to be put into the library itself)
| } | ||
|
|
||
| @Override | ||
| protected Flow createPanelGap(ModularPanel parent, PanelSyncManager syncManager) { |
There was a problem hiding this comment.
this might need to get changed after the pcb factory pr gets merged, since that changes how the gap is structured (although this might still work
| null)) | ||
| .size(225, 150) | ||
| .widgetTheme(GTWidgetThemes.TESLA_TOWER_CHART) | ||
| .renderTextureWithAlpha(0.05f) |
There was a problem hiding this comment.
this can probably be changed / removed with new modularui2 pr;s.
|
|
||
| private boolean renderMinMaxText = true; | ||
|
|
||
| private boolean renderTextureWithAlpha = false; |
There was a problem hiding this comment.
this stuff can probably go, as i said above.
| loadLegacyParameters(nbt); | ||
| return; | ||
| } | ||
| ((DoubleParameter) parameterMap.get("hysteresisLow")).setValue(nbt.getDouble("hysteresisLow")); |
There was a problem hiding this comment.
maybe the string values for these keys can be made into private static final constants. but this is a nitpick
| } | ||
|
|
||
| @Override | ||
| protected Flow createPanelGap(ModularPanel parent, PanelSyncManager syncManager) { |
There was a problem hiding this comment.
Batch mode, input sep, voiding, and recipe lock are not usable and do not make sense for this machine. should they be toggled off to not be enabled in the UI?
This port comes with the first implementation of new parameters. Instead of the old 40 button array you get a separate panel with titled buttons that open small panels that let you edit the chosen parameter.
2025-11-02.19-48-12.mp4
Besides porting the multiblock to mui2 i added a few features:
2025-10-26.01-04-09.mp4
2025-10-27.23-50-59.mp4
The transfer radius parameter has an upper bound of Integer.MAX_VALUE; This is intentional because that's how the current tesla behaves. The radius will be capped in the tesla rework, which is not the subject of this PR.