[MUI2] port Drone Centre to MUI2 #5320
Open
+2,638
−662
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrombread
added
Refactor
…to MUI2DroneCentre
Contributor
Author
|
It's finally done and ready for review, but i still need to test it on my server so please don't merge yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For a long time, the Drone Centre has had a puzzling "out of range" problem. This is actually because the current DC connection can only sync machines within the client's line of sight, and it displays "Out of range" when they are outside this line of sight (even though this "range" isn't referring to the drone's operational range). This PR will apply MUI2 to the DC and refactor its sync logic.
To-do:
close GTNewHorizons/GT-New-Horizons-Modpack#19872
close GTNewHorizons/GT-New-Horizons-Modpack#21934
close GTNewHorizons/GT-New-Horizons-Modpack#22538
close GTNewHorizons/GT-New-Horizons-Modpack#16362
shouldn't be merged before GTNewHorizons/ModularUI2#70done