Repository navigation
themes: an input: remote key asks live_tv_package first, and input_uri_scheme is the tile - #3231
Merged
Merged
Conversation
…i_scheme is the tile's
|
maintainer-bot review · suggests merge (p3) Thanks for checking the app_keys row against RemoteKeys.launch() and openInput(). The live_tv_package note and the Fluffy chooser example will save TCL owners some confusion, and this wording-only fix looks ready to merge as it is. Checks
This is a suggestion; a maintainer makes the final call. A maintainer can comment Reviewed by maintainer-bot · runs on 0G Private Computer |
4 of 6 tasks
Owner
|
Thanks @xbsheng, the themes README's app_keys row now says an input: key asks live_tv_package first and that input_uri_scheme is the tile, so the docs match how remote keys behave. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
app_keysrow said aninput:<input id>target switches to that TV input, and nothing else. Since themerge of #3173 (
RemoteKeys.launch,launcher/app/src/main/java/com/gathin/tvhome/RemoteKeys.java) thatswitch is aimed at
live_tv_packagefirst and only falls back to the bare channel URI, so the row now saysso: set
live_tv_package, or an app that also claims the channel URI (the Fluffy file manager on a TCL G03)can take the press or turn it into a chooser. It also says that
input_uri_schemeandinput_actionshape theInputs rows and a tile's
launch_actionsentry rather than a remote key:openInput()inMainActivityreadsboth,
RemoteKeys.launch()reads neither.One table row in
themes/README.md, no code, no new test (wording only).Tested on: no TV;
CLEANYOURTV_STRICT=1 tools/venv/bin/python -m unittest discover -s tests→ 2894 testsOK (skipped=26),
python3 tools/gen_tables.py --checkexit 0. The claims were read fromRemoteKeys.launch()and
MainActivity.openInput()on this branch.If this adds or changes a TV list
If this touches the launcher
If this adds or changes a theme