Repository navigation
Launcher: stock_home_redirect_delay_ms, to keep a launcherx screen opened over its home (#2779) - #2954
Launcher: stock_home_redirect_delay_ms, to keep a launcherx screen opened over its home (#2779)#2954TeaTax16 wants to merge 1 commit into
Conversation
|
maintainer-bot review · this one needs a maintainer decision · Leans: merge (65%) Thank you for the careful timing measurements on a real TV and the clear NOW/LATER/CANCEL tests. This looks ready to merge as an off-by-default, config-only extension of stock_home_redirect. A run on the BenQ GV32 itself would still be good to report back on #2779. Why it goes to a maintainer: changes the Home/launch path (HomeKeyService.java), which usually needs a run on a real TV (confidence 0.65 < 0.85). Checks
This is a suggestion; a maintainer makes the final call. A maintainer can comment Reviewed by maintainer-bot · runs on 0G Private Computer |
|
@TeaTax16 thank you, the delay is off by default, costs about 280 bytes, and the cancel-on-another-launcherx-window rule is neatly pinned by the HomeKeyServiceTest cases. Because it changes how stock_home_redirect sends Home back, and the MoGo never hits the bug itself, we'd like one run on a set that does before it goes in: @snoopyh42's GV32 at 400 ms, as you asked, is ideal. Nothing else is needed from you, and we'll look again in 7 days. |
…ened over its home (Gathin23#2779) stock_home_redirect can wait before sending the stock home back, and any other window of the stock launcher that comes up meanwhile cancels it, so Google TV's profile chooser stays on screen. Off (0) by default. Tried on an XGIMI MoGo 3 Pro by starting launcherx's home and then its chooser 70 ms later, as the BenQ GV32's profile button does: the chooser took 167-321 ms to show, and 400 kept it every time. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
f283a06 to
e428a49
Compare
|
@TeaTax16 thank you for the rebase and for keeping it to 232 B. The timing runs over launcherx are exactly what we needed. We are still waiting on one run on a set that really hits the bug. @snoopyh42, could you try stock_home_redirect_delay_ms at 400 on the GV32 and say whether the profile chooser stays up? We'll decide on 9 Nov. |
Adds
stock_home_redirect_delay_ms(0 to 2000, off by default):stock_home_redirectwaits that long before sending the stock home back, and any other window of the stock launcher that comes up meanwhile cancels it, so Google TV's profile chooser stays on screen. This is the first part of #2779; thekey_filterhalf is already the note inthemes/README.md.It costs 232 B: 588,361 B with this change on today's
main(588,129 B without it), against the 589,824 B gate. Rebased ontomainafter #3121; the MoGo 3 Pro list keeps one sentence saying this projector doesn't need the delay.Tested on: XGIMI MoGo 3 Pro (G0035), Google TV 14, build UKNV.260707.001.15802496
How it was tried: the MoGo's own profile button goes through XGIMI's xrmservice, which opens the chooser directly, with no launcherx home first, so it never hits this bug. I reproduced the BenQ GV32 sequence from the issue with
am startof.home.HomeActivityand then.profile.chooser.ProfileChooserActivity70 ms later, with launcherx enabled:So the docs suggest 400. @snoopyh42, could you try 400 on the GV32, where the profile button starts the home itself?
If this touches the launcher
values/strings.xmland the othervalues-*folders: not applicable, no new stringsconfig.xmlor a theme, not in codeIf this adds a theme key (a switch)
docs/switches.mdChecks:
testReleaseUnitTest lintRelease assembleReleasewith zero lint errors; the Python suite passes (2,894 tests). Six JVM tests inHomeKeyServiceTestcover the redirect decision.Part of #2779.
🤖 Generated with Claude Code