Repository navigation
Conversation
…direct On Fire OS, Amazon's launcher can't be disabled and outranks set-home-activity, so with STOCK_LAUNCHER=none Home never resolves to this launcher and build-and-install stopped with "Home resolves to ..., not to the new launcher" before it enabled HomeKeyService. With STOCK_LAUNCHER=none and HOME_KEY_SERVICE=1 that state is the intended one (nothing was disabled, stock_home_redirect sends the stock home here), so the script now says so and carries on. Same in build-and-install.ps1. Without HOME_KEY_SERVICE it stops as before. Tested on a Fire TV Stick 4K (AFTKM), Fire OS 8.1.8.2. The AFTKM list's header, its tv.json note, the README's Fire TV row and the stock_home_redirect row in themes/README.md say how. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
maintainer-bot review · this one needs a maintainer decision Thanks for the careful AFTKM timings and the two new handover tests, which show the old stop still happens without HomeKeyService. This changes the Home check in the install scripts and changes the project's Fire OS stance from "debloat only", so it needs the maintainer's decision before it goes further. Why it goes to a maintainer: the bot asks for a maintainer decision. Checks
This is a suggestion; a maintainer makes the final call. A maintainer can comment Reviewed by maintainer-bot · runs on 0G Private Computer |
|
Re the #3005 note: they touch different steps. #3005 picks |
|
@Achar0 thank you for the careful AFTKM timings and for the test proving the old stop still happens without HomeKeyService. This touches the install scripts' Home check on the stock_home_redirect route, so it gets a real-TV run of that path on an Android TV before it merges. If you can, a Windows run of the .ps1 change would help, and please rebase if #3005 lands first. |
|
Thanks! I only have the Fire TV Stick (AFTKM), so I can't do the Android TV run myself — if anyone here has a Google TV / Android TV on the |
|
Windows run of the
It ended with Full output |
|
@Achar0 thank you for the Windows .ps1 run on the stick: that closes the last open item on your side, and the Fire OS timings are excellent. Since this touches the install scripts' Home check on the stock_home_redirect route, it gets one run on an Android TV before it merges. If #3005 or #2954 lands first, please rebase; the README row alone needs no rebase. |


On Fire OS, Amazon's launcher can't be disabled and outranks
set-home-activity. So withSTOCK_LAUNCHER=none, Home never resolves to this launcher, andbuild-and-install.shstopped with "Home resolves to …, not to the new launcher" before it enabledHomeKeyService. That is why the Fire OS lists say "debloat only", althoughstock_home_redirectalready works on Fire OS once the service is on.What changes
build-and-install.sh/.ps1: withSTOCK_LAUNCHER=noneandHOME_KEY_SERVICE=1, a Home that stays on the stock launcher is the intended state, because nothing was disabled. The script says "Home stays …; HomeKeyService sends it here (stock_home_redirect)" and carries on. WithoutHOME_KEY_SERVICEit stops exactly as before.tests/test_launcher_handover.py: two cases on the simulated TV, the kept Home with the redirect (installs, enables HomeKeyService, disables nothing) and without it (still stops).tv.jsonnote, the README's Fire TV row, and thestock_home_redirectrow inthemes/README.md.Tested on a Fire TV Stick 4K (AFTKM), Fire OS 8.1.8.2. The test build used
-PlauncherApplicationIdso it sat next to another launcher; the script was otherwise unchanged.STOCK_LAUNCHER=none HOME_KEY_SERVICE=1.set-home-activityanswered "Success", but Home still resolved tocom.amazon.tv.launcher/.ui.HomeActivity_vNext. Unpatched, the script stops at that check.key_filterdoesn't matter there.MainSettingsActivitydirectly, so Amazon's home never shows on the way. Wi-Fi opens, and Back from both returns to the launcher.python3 -m unittest discover -s tests: 2864 tests OK (35 skipped, the same as main).Not done here
Screenshots from the stick: [attached below]