Repository navigation
README: the four translated front pages state the 228 projects SHOWCASE.md holds - #3577
Merged
Merged
Conversation
…228 projects SHOWCASE.md holds SHOWCASE.md opens with 228 projects so far and README.md and README.pt-BR.md say the same. The four translated pages carried the same row and nothing read it: nl wrote 121 in digits, de spelled hundertvierundvierzig, uk spelled сто шістдесят три, and uz spelled ikki yuz oʻn ikkita. They now write the number in digits, the shape a reader can follow in any language.
digits_number() reads "228" and "228 ta" (the Uzbek classifier sits between the number and its noun), COUNT_PAGES replaces SPELLED_PAGES with the four pages, a floor keeps the table from shrinking, and digits are now one word to the reader that splits the line. docs/workflows/showcase.md step 2 names the six pages and the table.
|
maintainer-bot review · suggests merge (p3) Thanks for tracking down the stale showcase counts on the German, Dutch, Ukrainian and Uzbek front pages, and for the clear table showing each one. Writing the count in digits so the existing test can check every page is a neat fix, and this looks ready to merge as it is. Checks
This is a suggestion; a maintainer makes the final call. A maintainer can comment Reviewed by maintainer-bot · runs on 0G Private Computer |
This was referenced Nov 8, 2026
Owner
|
Thank you @xbsheng, the Dutch, German, Ukrainian and Uzbek front pages now state the 228 projects SHOWCASE.md holds, in digits, and test_showcase_project_count.py reads all four. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SHOWCASE.mdopens with228 projects so far.,README.mdspells the same number ("two hundred and twenty-eight") andREADME.pt-BR.mdspells it in Portuguese. The "Built something on top?" row is on five more translated front pages, and nothing read any of them:README.nl.mdREADME.de.mdREADME.uk.mdREADME.uz.md-taclassifier)tests/test_showcase_project_count.pycounted the rows and readREADME.mdandREADME.pt-BR.mdonly. The other four were unread because their number is written in a shape the two word parsers cannot follow: a German compound, a Ukrainian spelled number, an Uzbek numeral carrying-ta, and — for nl — digits, which the line-splitter did not even hand to a reader (it kept letters only).Reproduced on
294d3d59with only this branch's test file added to the tree and nothing else changed:and with the four sentences written the way the check reads them, at the numbers they carried, each page is named:
The fix, +84 −25 in 6 files:
README.tr.mdalready uses for this row and the oneREADME.nl.mdhad — deliberately not four more number parsers, because a German compound and an Uzbek classified numeral are not words a table can hold (the same reasonREADME.uz.md's theme count moved to digits in README: the Uzbek front page states the 28 themes the tree holds #3573).tests/test_showcase_project_count.py:digits_number()reads228and228 ta(the classifier between the number and its noun) and refuses a spelled number or one with a separator; the line-splitter now keeps digits, so a number in digits reaches its reader at all;SPELLED_PAGESbecomesCOUNT_PAGESwith the six pages; a floor of six pages so a dropped page cannot quietly stop being judged; two reader tests (digits read,228 taread, a spelled row read as nothing).docs/workflows/showcase.mdstep 2: the count is stated on six front pages, two in words and four in digits, and a translation that states it joinsCOUNT_PAGES. The step quotes no live number, so it cannot go stale itself.Nothing in
launcher/,examples/,themes/,PROMPT.md,tools/, the Home guard or.github/is touched.Checked for duplicates: all 80 open PRs' file lists were read through the REST API. Five touch one of these pages and none within 100 lines of the four rows: #3164 (
README.nl.mdbadge and licence lines, both ends of the file), #3300 (nl:521), #3040 (nl:28,nl:681,de:20,de:260,uk:20,uk:283), #2569 (nl:26,nl:128,nl:253,de:20,de:135), #2545 (nl:26,nl:619,de:20,de:257). Nobody touchestests/test_showcase_project_count.py.git merge-tree --write-treeagainst my own open #3569, which edits step 1 of the same recipe, answers exit 0.Tested on: no TV — four front pages and a unit test over the checkout, unit tests only.
If this adds or changes a TV list
tv.jsonIf this touches the launcher
If this adds or changes a theme
If this adds a theme key (a switch)
If this adds an add-on
Self-check: no POLICY red line touched (no install restriction, no uninstall, no root, no launcher network, no maintainer-only path, no new default for every TV); one topic;
CLEANYOURTV_STRICT=1 tools/venv/bin/python -m unittest discover -s tests→Ran 3211 tests, OK (skipped=36)= main's 3209 + 2;tools/venv/bin/python -I tools/gen_tables.py --checkexit 0; no shell changed.