Repository navigation
Launcher: Japanese (values-ja), every translatable string - #3040
LostInInaka wants to merge 1 commit into
Conversation
|
maintainer-bot review · suggests merge (p2) Thank you for the careful Japanese translation: the labels are short enough for a TV, and every format argument was checked against the source. This looks ready to merge as a strings-only launcher translation. Checks
This is a suggestion; a maintainer makes the final call. A maintainer can comment Reviewed by maintainer-bot · runs on 0G Private Computer |
30bf0df to
09b24d2
Compare
|
Thank you @LostInInaka, this reads like it was written for a TV: 未接続, 12時間表示, and every format argument checked against the source. It adds about 8.3 KB and goes 5.9 KB past the size gate. That makes it the same maintainer call as #2545, so we're keeping it open alongside that one rather than trimming it. We can't promise when room will come, and thank you for offering to keep it rebased. |
… today's main The launcher ships thirty translated languages and English, and Japanese is not one of them — on a launcher whose tested list has a Sharp AQUOS and a Sony BRAVIA on it. `values-ja` adds all 145 translatable strings, written for a TV: short labels, product names left alone, help strings cut to two or three sentences so they fit a tile. `date_format_home` is absent on purpose: it is `translatable="false"` and aliases the translated `@string/date_format`. `library_app_count` keeps `quantity="other"`, as `values-ko` does — Japanese has no plural. Every format argument was checked against the source: same set, same order, and `race_next` keeps `%1$s` before `%2$s` so it reads 予選まで3時間. Wired the way the tests ask: `res/xml/locales_config.xml`, the Languages list in `docs/launcher.md`, `NAMES` in `tests/test_locales_registered.py`, and the generated counts, which now read 407 TV models, 106 brands and 32 languages — the numbers this commit measured, not the ones the branch was cut from. The size gate, stated plainly: 595,337 B with this locale against 587,065 B on the same main without it, i.e. 5,513 B past the 589,824 B gate in `ci.yml`. `docs/workflows/translation.md` step 7 makes a locale that does not fit the maintainer's call rather than something to trim strings for, so nothing was trimmed. The rest of the suite is green: 2743 tests, one failure — the pre-existing `disable.ps1` PowerShell colour case, which fails the same way on `main`.
09b24d2 to
aa4586d
Compare
|
@Gathin23 — Rebased onto today's
Counts regenerated from the tree: 427 TV models, 111 brands, 32 languages, card and alt text redrawn, |
|
@Gathin23 — the room you were waiting for is in review: #3156 takes 18,764 B back by shipping the bundled Outfit variable font clipped to the four weights So I measured this branch with it. Same head as here (
314 launcher cases green, nothing trimmed, gate untouched — Which means the gate no longer has to decide this PR, if #3156 goes first. I will keep this rebased either way; if the order happens to be the other way round I will rebase onto it and re-measure. One housekeeping note on the collision the bot raised: #2545 also takes the language count from 31 to 32, so whichever of the two merges second regenerates the counts ( |
|
One correction to the figure I gave you yesterday, because it moved: the typeface trim now keeps weight 100 in its axis (the bare Same head as here ( |
|
@Gathin23 — a heads-up that costs you nothing to ignore: this branch is now 402 commits behind |
The launcher ships thirty translated languages plus English, and Japanese is not one of them — which is
odd for a launcher whose tested list has a Sharp AQUOS and a Sony BRAVIA on it. This adds
values-jawithall 145 strings and the one
pluralsresource, written for a TV rather than for a desktop: short labels, 設定 and アプリ and壁紙 where Japanese says them, product names left alone, and the long help strings cut to two or three
sentences so they fit on a tile.
date_format_homeis not in the file: it istranslatable="false"and aliases@string/date_format,which is translated.
library_app_countkeepsquantity="other"only, asvalues-kodoes — Japanese has no plural.%1$s,%1$d,%2$s,%1$.0f,%1$d%%): sameset, same order.
race_nextkeeps%1$sbefore%2$sso it reads 「予選まで3時間」.res/xml/locales_config.xml, the Languages list indocs/launcher.md,NAMESintests/test_locales_registered.py, and the generated counts.tools/gen_tables.pynow reads416 TV models, 106 brands and 32 languages,
--checkexits 0, and the card and its alt text were redrawnto match.
fonts.xml:zhandkoship without one and Android's fallback covers the glyphs.The size gate, up front. On today's
main(3cd274f8) the release APK is 587,437 B without thislocale and 595,709 B with it — 5,885 B past the 589,824 B gate in
ci.yml, andmainitself carriesonly 2,387 B of headroom before this branch starts.
docs/workflows/translation.mdstep 7 says a locale that doesnot fit is the maintainer's call rather than something to trim strings for, so nothing has been trimmed.
This is #2545's situation rather than a new one (its 5,149 B over is a shade less than this one's), and I read your answer there — it stays open while you look
for room in the launcher's own images — so this one is here to wait too, and I'll keep it rebased until
there is room. Sizes are from a clean
assembleReleaseon my machine; yourmainis documented at585,489 B where mine builds 587,437 B from the same tree, so treat the figures as ±2 KB and the delta
between them as the real number.
Everything else is green: 2788 tests, one failure, and that one
(
test_disable_ps1_refuses_the_bare_names_before_touching_the_tv, a PowerShell colour case) failsidentically on
mainin the same environment — I ran both to be sure.It has been through a revision pass on how the Japanese reads, which is where much of the diff comes from: the Dussehra
greeting was ドゥシェラ and is now ダシェラ; デバイスなし for "not connected" became 未接続; TVのシステム設定
became システム設定; 「12時間」/「24時間」 became 「12時間表示」/「24時間表示」; the home-settings help lost its
machine-translated clause order; and a line in
README.ja.mdthat still said the launcher has no Japanesenow says how to set the app's own language to
ja. 有線LAN, スタンバイ and フリー走行 were keptdeliberately, so a native speaker may still want to argue about three words.