Improve address creation error messages#194
Merged
jacktoncelli merged 9 commits intomainfrom Nov 30, 2025
Merged
Conversation
Contributor
jacktoncelli
left a comment
jacktoncelli
left a comment
There was a problem hiding this comment.
Looks good, one thing to change
| const transformedPayload = await Promise.all( | ||
| payload.map(async (element) => { | ||
| const currFips = await this.locationMatcher.getLocationFips(element); | ||
| if (!currFips || currFips.fipsStateCode === null || currFips.fipsCountyCode === null) { |
Contributor
There was a problem hiding this comment.
can you also add this to the createLocationAddress method in this file for single creation? That way we see a good error in the business profile page? You may also have to modify the createLocation method in frontend/api/location.ts
Contributor
There was a problem hiding this comment.
I think it also needs to be added here, otherwise it doesn't show on a single creation in business profile page
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
[Link to Ticket](insert the link to your ticket inside the parenthesis here)
Please include a summary of the changes. If there were unexpected changes
to separate processes/components/dependencies, please explain why. Bullet list is fine!
Backend PRs:
Frontend PRs:
Page route(and description of how to get desired flow if necessary)
Please include any relevant images of the changes here.
Did any new/other issues pop up?
No
Checklist