Improve address creation error messages

.gitignore

@@ -2,5 +2,6 @@
 .idea/
 log
 .DS_Store
+backend/tmp/
 
 .vscode/

backend/src/modules/location-address/service.ts

@@ -137,6 +137,11 @@ export class LocationAddressService implements ILocationAddressService {
             const transformedPayload = await Promise.all(
                 payload.map(async (element) => {
                     const currFips = await this.locationMatcher.getLocationFips(element);
+                    if (!currFips || currFips.fipsStateCode === null || currFips.fipsCountyCode === null) {
+                        throw Boom.badRequest(
+                            `Please enter a valid address. Unable to validate address: ${element.streetAddress}, ${element.city}, ${element.stateProvince}.`
+                        );
+                    }
                     return { ...element, ...currFips };
                 })
             );

backend/src/types/Location.ts

@@ -11,7 +11,7 @@ export const LocationAddressSchema = z.object({
     city: z.string(),
     streetAddress: z.string(),
     postalCode: z.string().nonempty().regex(/^\d+$/, {
-        message: "Must be a non-negative number string",
+        message: "Please enter a valid Postal Code. Must be a non-negative number.",
     }),
     county: z.string().optional(),
     companyId: z.uuid(),
@@ -29,7 +29,7 @@ export const LocationAddressSchemaType = z.object({
     city: z.string(),
     streetAddress: z.string(),
     postalCode: z.string().nonempty().regex(/^\d+$/, {
-        message: "Must be a non-negative number string",
+        message: "Please enter a valid Postal Code. Must be a non-negative number.",
     }),
     county: z.string().optional(),
     companyId: z.uuid(),
@@ -45,7 +45,7 @@ export const CreateLocationAddressSchema = z.object({
     city: z.string().nonempty(),
     streetAddress: z.string().nonempty(),
     postalCode: z.string().nonempty().regex(/^\d+$/, {
-        message: "Must be a non-negative number string",
+        message: "Please enter a valid Postal Code. Must be a non-negative number.",
     }),
     county: z.string().nonempty().optional(),
 });
@@ -72,7 +72,7 @@ export const GetAllLocationAddressesSchema = z.array(
         city: z.string().nonempty(),
         streetAddress: z.string().nonempty(),
         postalCode: z.string().nonempty().regex(/^\d+$/, {
-            message: "Must be a non-negative number string",
+            message: "Please enter a valid Postal Code. Must be a non-negative number.",
         }),
         county: z.string().nonempty().optional(),
         companyId: z.uuid(),
@@ -93,7 +93,7 @@ export const UpdateLocationAddressDTOSchema = z.object({
     postalCode: z
         .string()
         .regex(/^\d+$/, {
-            message: "Must be a non-negative number string",
+            message: "Please enter a valid Postal Code. Must be a non-negative number.",
         })
         .optional(),
     county: z.string().optional().nullable(),

backend/src/utilities/error.ts

@@ -24,7 +24,7 @@ export const withServiceErrorHandling = <T extends any[], R>(handler: (...args:
                     case "23502":
                         throw Boom.badRequest("Missing required field");
                     default:
-                        throw Boom.internal(error, { message: "An expected error occured" });
+                        throw Boom.internal(error, { message: "An unexpected error occured" });
                 }
             } else {
                 throw Boom.boomify(error);

frontend/api/location.ts

@@ -36,7 +36,13 @@ export const createLocationBulk = async (payload: CreateLocationBulkRequest): Pr
         if (response.ok) {
             return data!;
         } else {
-            throw Error(error?.error);
+            const apiError = new Error(error?.error || "Failed to create locations - Unkown Error") as Error & {
+                status: number;
+                statusText: string;
+            };
+            apiError.status = response.status;
+            apiError.statusText = response.statusText;
+            throw apiError;
         }
     };
     return authWrapper<Location[]>()(req);

frontend/app/signup/company.tsx

@@ -73,7 +73,8 @@ export default function Company({ handleNext: incrementNext }: CompanyInfoProps)
             incrementNext();
         },
         onError: (_error: Error) => {
-            setLocError("Error creating locations. Check required fields and try again");
+            const errorMessage = _error.message || "Error creating locations. Check required fields and try again";
+            setLocError(errorMessage);
         },
     });