Skip to content

fix: race condition in mobile config setter#263

Merged
Dao-Ho merged 2 commits intomainfrom
dao/fix-race-condition
Apr 4, 2026
Merged

fix: race condition in mobile config setter#263
Dao-Ho merged 2 commits intomainfrom
dao/fix-race-condition

Conversation

@Dao-Ho
Copy link
Copy Markdown
Contributor

@Dao-Ho Dao-Ho commented Apr 4, 2026

wrapped in useEffect which fired after component render, therefore getter was called before our config setter

@Dao-Ho Dao-Ho marked this pull request as ready for review April 4, 2026 17:28
@Dao-Ho Dao-Ho merged commit e89757c into main Apr 4, 2026
5 checks passed
@Dao-Ho Dao-Ho deleted the dao/fix-race-condition branch April 4, 2026 17:30
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 4, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.00%. Comparing base (f50955a) to head (0ec71c2).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main     #263       +/-   ##
===========================================
+ Coverage   18.24%   84.00%   +65.75%     
===========================================
  Files          42        7       -35     
  Lines        1716       50     -1666     
  Branches        0       24       +24     
===========================================
- Hits          313       42      -271     
+ Misses       1397        8     -1389     
+ Partials        6        0        -6     
Flag Coverage Δ
backend ?
mobile 84.00% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 49 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant