Skip to content

fix: race condition in mobile config setter #263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Dao-Ho merged 2 commits into from
Apr 4, 2026
+4 −8
Merged

fix: race condition in mobile config setter #263

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
11a909b
remove useEffect
Dao-Ho Apr 4, 2026
0ec71c2
rm unused cmt
Dao-Ho Apr 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 4 additions & 8 deletions clients/mobile/app/_layout.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ import { tokenCache } from "@clerk/clerk-expo/token-cache";
import { ClerkProvider, ClerkLoaded, useAuth } from "@clerk/clerk-expo";
import { useColorScheme } from "@/hooks/use-color-scheme";
import { setConfig } from "@shared";
import { useEffect } from "react";

// Client explicity created outside component to avoid recreation
const queryClient = new QueryClient({
Expand All @@ -34,13 +33,10 @@ export const unstable_settings = {
// Component to configure auth provider and the api base url
function AppConfigurator() {
const { getToken } = useAuth();
useEffect(() => {
setConfig({
API_BASE_URL: process.env.EXPO_PUBLIC_API_BASE_URL ?? "",
getToken,
});
}, [getToken]);

setConfig({
API_BASE_URL: process.env.EXPO_PUBLIC_API_BASE_URL ?? "",
getToken,
});
return null;
}

Expand Down
Loading