[BUG FIX] Fix MPR warm-start infinite loop edge case.#1336
Merged
duburcqa merged 8 commits intoGenesis-Embodied-AI:mainfrom Jun 30, 2025
Merged
[BUG FIX] Fix MPR warm-start infinite loop edge case.#1336duburcqa merged 8 commits intoGenesis-Embodied-AI:mainfrom
duburcqa merged 8 commits intoGenesis-Embodied-AI:mainfrom
Conversation
YilingQiao
previously approved these changes
Jun 29, 2025
YilingQiao
previously approved these changes
Jun 30, 2025
Genesis-Embodied-AI
approved these changes
Jun 30, 2025
Milotrince
pushed a commit
to Milotrince/Genesis
that referenced
this pull request
Jul 5, 2025
…ed-AI#1336) * Disable timers by default. * Fix compiler warnings for excessive inlining. * Fix running benchmarks sequentially. * Fix benchmark master worker id shadowing. * Fix contribution guidelines. * Re-enable warning for exceeding max collision pairs. * Offset geometry centers for MPR only if necessary. * Fix MPR warm-start infinite loop edge case.
chris-la-humalab
pushed a commit
to HumaLab/Genesis
that referenced
this pull request
Aug 1, 2025
…ed-AI#1336) * Disable timers by default. * Fix compiler warnings for excessive inlining. * Fix running benchmarks sequentially. * Fix benchmark master worker id shadowing. * Fix contribution guidelines. * Re-enable warning for exceeding max collision pairs. * Offset geometry centers for MPR only if necessary. * Fix MPR warm-start infinite loop edge case.
YilingQiao
pushed a commit
to YilingQiao/Genesis
that referenced
this pull request
Aug 22, 2025
…ed-AI#1336) * Disable timers by default. * Fix compiler warnings for excessive inlining. * Fix running benchmarks sequentially. * Fix benchmark master worker id shadowing. * Fix contribution guidelines. * Re-enable warning for exceeding max collision pairs. * Offset geometry centers for MPR only if necessary. * Fix MPR warm-start infinite loop edge case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Note that no unit test has been added for this MPR edge-case because it is too extremely difficult to trigger reliably. That would be too much work for not enough value.
Related Issue
Resolves /issues/1123
Checklist:
Submitting Code Changessection of CONTRIBUTING document.