[BUG FIX] Add angular damping to drone to prevent numerical instability#1348
Merged
YilingQiao merged 2 commits intoGenesis-Embodied-AI:mainfrom Jul 8, 2025
Merged
Conversation
Collaborator
|
What about making this the default for Drone in general. Not just this example. Because I think this issue is more general. I can do it if you don’t want to spend time on it. |
Collaborator
|
By the way, I changed “Resolve” for “Related”. Because I don’t think it is addressing the root cause of the issue, but it mitigates it successfully. |
YilingQiao
approved these changes
Jul 7, 2025
Collaborator
Do you mean damping parameter for rotational DoFS? |
This was referenced Jul 8, 2025
chris-la-humalab
pushed a commit
to HumaLab/Genesis
that referenced
this pull request
Aug 1, 2025
LeonLiu4
pushed a commit
to LeonLiu4/Genesis
that referenced
this pull request
Aug 7, 2025
YilingQiao
pushed a commit
to YilingQiao/Genesis
that referenced
this pull request
Aug 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a bug where the drone simulation could become numerically unstable due to unbounded angular velocities.
🔧 What changed:
self.drone.set_dofs_damping(torch.tensor([0.0, 0.0, 0.0, 1e-4, 1e-4, 1e-4]))No other functional or API changes were made.
Related Issue
Related to #909
Motivation and Context
How Has This Been / Can This Be Tested?
Yes. The training still works as before
Also tested with the following minimum example
Screenshots (if appropriate):
Checklist:
Submitting Code Changessection of CONTRIBUTING document.