[Bug] Fix memory OOM in Genesis push_differentiable example#228
Merged
hughperkins merged 6 commits intomainfrom Oct 7, 2025
Merged
[Bug] Fix memory OOM in Genesis push_differentiable example#228hughperkins merged 6 commits intomainfrom
hughperkins merged 6 commits intomainfrom
Conversation
yun-long
approved these changes
Sep 26, 2025
Collaborator
Author
|
We will likely replace this with something like #229 => draft for now. |
Collaborator
Author
|
Actually, it's not clear to me that non-static ranges should fail. So let's merge this anyway. (albeit likely with @yun-long 's suggestion incorporated to make this a bit more principled). |
duburcqa
approved these changes
Oct 6, 2025
|
LGTM |
SonSang
approved these changes
Oct 7, 2025
YilingQiao
approved these changes
Oct 7, 2025
Collaborator
Author
|
Thanks! |
Collaborator
Author
|
whoopa, this code has a bug. Not sure how unit tests passed 🤔 Anyway, I will add create a new PR with a unit test that exercises the bug, and a fix for the bug. |
Collaborator
Author
Collaborator
Author
|
(In case anyone's curious what the bug is, there shouldn't be an ) |
Collaborator
Author
7 tasks
YilingQiao
pushed a commit
to Genesis-Embodied-AI/Genesis
that referenced
this pull request
Oct 10, 2025
- Associated gstaichi PR: Genesis-Embodied-AI/gstaichi#228
ACMLCZH
pushed a commit
to ACMLCZH/Genesis
that referenced
this pull request
Oct 13, 2025
- Associated gstaichi PR: Genesis-Embodied-AI/gstaichi#228
jmCabrillana
pushed a commit
to jmCabrillana/Genesis
that referenced
this pull request
Dec 9, 2025
- Associated gstaichi PR: Genesis-Embodied-AI/gstaichi#228
Kashu7100
pushed a commit
to Kashu7100/Genesis
that referenced
this pull request
Jan 26, 2026
- Associated gstaichi PR: Genesis-Embodied-AI/gstaichi#228
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: #
Brief Summary
ptrattributeBefore Genesis migrated to gstaichi, in Genesis-Embodied-AI/Genesis#1550, push_differentiable used to use ~22GB of memory, which we can observe by running
while true; do { nvidia-smi | grep 575W; sleep 1; } donein parallel, in a second terminal session:After migrating to gstaichi, this test used ~32GB of memory:
This PR fixes this regression, so this test uses ~22GB of memory again.
The extra memory was being used because we were parsing incoming kernel parameters multiple times. This PR modifies the code so that each kernel parameter is only processed once.
copilot:summary
Walkthrough
copilot:walkthrough