Skip to content

Fix llvm mac build - #12

Merged
hughperkins merged 3 commits into
mainfrom
hp/fix-llvm-mac-build
Oct 7, 2025
Merged

Fix llvm mac build#12
hughperkins merged 3 commits into
mainfrom
hp/fix-llvm-mac-build

Conversation

@hughperkins

@hughperkins hughperkins commented Oct 7, 2025

Copy link
Copy Markdown
Collaborator

see failures such as https://github.com/Genesis-Embodied-AI/gstaichi/actions/runs/18300984728/job/52108893427?pr=216

binary search on the llvm builds found:

202509261351 => fail
202509261125 => fail
202509212040 => ok

202509202046 => ok

Using this branch:

202510070835 (remove strip) => ok
202510070832 (baseline: no change) => fail

This PR removes strip from mac build, which fixes the gstaichi mac build.

Size of mac os x llvm asset chagnes from 696MB to 784MB, which seems an acceptable-ish change, for a build that works.

Note that the artifacts from this build are not directly user-visible for gstaichi users:

  • this build will be linked with the c++ code from gstaichi
  • then we run strip the resulting wheel

@hughperkins

Copy link
Copy Markdown
Collaborator Author

Thanks!

@hughperkins
hughperkins merged commit 50e093e into main Oct 7, 2025
9 of 10 checks passed
@hughperkins
hughperkins deleted the hp/fix-llvm-mac-build branch October 7, 2025 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants