Fix llvm mac build - #12
Merged
Merged
Conversation
CharlesMasson
approved these changes
Oct 7, 2025
duburcqa
approved these changes
Oct 7, 2025
Collaborator
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see failures such as https://github.com/Genesis-Embodied-AI/gstaichi/actions/runs/18300984728/job/52108893427?pr=216
binary search on the llvm builds found:
Using this branch:
This PR removes strip from mac build, which fixes the gstaichi mac build.
Size of mac os x llvm asset chagnes from 696MB to 784MB, which seems an acceptable-ish change, for a build that works.
Note that the artifacts from this build are not directly user-visible for gstaichi users: