Skip to content

Conversation

@dsuren1
Copy link

@dsuren1 dsuren1 commented Jan 21, 2025

Description

This PR fixes the layer settings component used for internal layers

Issue

@dsuren1 dsuren1 added bug Something isn't working geonode-ui 4.4.x labels Jan 21, 2025
@dsuren1 dsuren1 requested a review from allyoucanmap January 21, 2025 06:35
@dsuren1 dsuren1 self-assigned this Jan 21, 2025
@dsuren1 dsuren1 linked an issue Jan 21, 2025 that may be closed by this pull request
Comment on lines +90 to +93
},
{
"name": "selectedLayer",
"path": "gnresource.selectedLayer"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dsuren1 is it possible to use just one of gnResourceSelectedLayerDataset or selectedLayer or do they are different?
Could you investigate on where the gnResourceSelectedLayerDataset is used and if it can be replaced by selectedLayer, thanks

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@allyoucanmap It seems each holds a different data. selectedLayer holds selected node (layer) and selectedLayerDataset holds dataset info available in mapLayers by selected node

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the dataset fetch is asynchronous, there is a visual transition between TOCItemSetting and the LayerSetting plugin as the dataset is being retrieved. Therefore, I believe we should proceed with the current implementation as agreed

@allyoucanmap allyoucanmap merged commit 89a25af into GeoNode:master Feb 5, 2025
4 checks passed
github-actions bot pushed a commit that referenced this pull request Feb 5, 2025
giohappy pushed a commit that referenced this pull request Feb 5, 2025
ridoo pushed a commit to 52North/geonode-mapstore-client that referenced this pull request Mar 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The layers settings for internal layers are using the wrong component

2 participants