Use scroll offset for loading more content in channel and message list #838
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SDK Size
|
laevandus
force-pushed
the
feature/offset-based-load-more
branch
from
ac9bc95 to
cc0353f
Compare
laevandus
commented
May 27, 2025
| func onScrollPaginationChanged( | ||
| in coordinateSpace: CoordinateSpace = .global, | ||
| flipped: Bool = false, | ||
| threshold: CGFloat = 400, |
There was a problem hiding this comment.
Might need some fine-tuning
laevandus
commented
May 27, 2025
Comment on lines
+27
to
+36
| func handleGeometryChanged(_ geometry: GeometryProxy) { | ||
| let frame = geometry.frame(in: coordinateSpace) | ||
| guard frame.size.height > 0 else { return } | ||
| let offset = -frame.minY | ||
| if offset + UIScreen.main.bounds.height + threshold > frame.height { | ||
| flipped ? onTopThreshold?() : onBottomThreshold() | ||
| } else if offset < threshold { | ||
| flipped ? onBottomThreshold() : onTopThreshold?() | ||
| } | ||
| } |
There was a problem hiding this comment.
It is way too difficult to get the height of the visible rect for precise calculations. Therefore, using inaccurate screen height here for simplifying it.
Geometry gives the height of the whole content view.
There was a problem hiding this comment.
this might slow things down though, wdyt?
There was a problem hiding this comment.
Yeah overall, it feels like on develop, things load faster and are bit smoother. 🤔
laevandus
force-pushed
the
feature/offset-based-load-more
branch
from
cc0353f to
a2fc6a8
Compare
# Conflicts: # CHANGELOG.md
|
Comment on lines
+27
to
+36
| func handleGeometryChanged(_ geometry: GeometryProxy) { | ||
| let frame = geometry.frame(in: coordinateSpace) | ||
| guard frame.size.height > 0 else { return } | ||
| let offset = -frame.minY | ||
| if offset + UIScreen.main.bounds.height + threshold > frame.height { | ||
| flipped ? onTopThreshold?() : onBottomThreshold() | ||
| } else if offset < threshold { | ||
| flipped ? onBottomThreshold() : onTopThreshold?() | ||
| } | ||
| } |
There was a problem hiding this comment.
this might slow things down though, wdyt?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Issue Links
Resolves: IOS-793
🎯 Goal
If channel list is scrolled very quickly while it is loading a new page it stops loading additional pages
📝 Summary
onScrollPaginationChanged(in:flipped:threshold:onBottomThreshold:onTopThreshold:)MessageListandChannelListusesContentOffsetBasedLoadMore(since public init methods get additional arguments)🛠 Implementation
The new modifier adds
GeometryReaderto the background of the view which gives us scrolled offset and the content size. Based on the threshold, it calls one of the closures which in turn has to be hooked up the view model for loading new pages.🎨 Showcase
🧪 Manual Testing Notes
Explain how this change can be tested manually, if applicable.
☑️ Contributor Checklist
docs-contentrepo