-
Notifications
You must be signed in to change notification settings - Fork 99
Use scroll offset for loading more content in channel and message list #838
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
57 changes: 57 additions & 0 deletions
57
Sources/StreamChatSwiftUI/Utils/ScrollViewPaginationViewModifier.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,57 @@ | ||
// | ||
// Copyright © 2025 Stream.io Inc. All rights reserved. | ||
// | ||
|
||
import Foundation | ||
import SwiftUI | ||
|
||
private struct ScrollViewPaginationViewModifier: ViewModifier { | ||
let coordinateSpace: CoordinateSpace | ||
let flipped: Bool | ||
let threshold: CGFloat | ||
let onBottomThreshold: () -> Void | ||
let onTopThreshold: (() -> Void)? | ||
|
||
func body(content: Content) -> some View { | ||
content | ||
.background( | ||
GeometryReader { geometry in | ||
Color.clear | ||
.onChange(of: geometry.frame(in: coordinateSpace)) { _ in | ||
handleGeometryChanged(geometry) | ||
} | ||
} | ||
) | ||
} | ||
|
||
func handleGeometryChanged(_ geometry: GeometryProxy) { | ||
let frame = geometry.frame(in: coordinateSpace) | ||
guard frame.size.height > 0 else { return } | ||
let offset = -frame.minY | ||
if offset + UIScreen.main.bounds.height + threshold > frame.height { | ||
flipped ? onTopThreshold?() : onBottomThreshold() | ||
} else if offset < threshold { | ||
flipped ? onBottomThreshold() : onTopThreshold?() | ||
} | ||
} | ||
} | ||
|
||
extension View { | ||
func onScrollPaginationChanged( | ||
in coordinateSpace: CoordinateSpace = .global, | ||
flipped: Bool = false, | ||
threshold: CGFloat = 400, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. From UIKit SDK There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Might need some fine-tuning |
||
onBottomThreshold: @escaping () -> Void, | ||
onTopThreshold: (() -> Void)? = nil | ||
) -> some View { | ||
modifier( | ||
ScrollViewPaginationViewModifier( | ||
coordinateSpace: coordinateSpace, | ||
flipped: flipped, | ||
threshold: threshold, | ||
onBottomThreshold: onBottomThreshold, | ||
onTopThreshold: onTopThreshold | ||
) | ||
) | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is way too difficult to get the height of the visible rect for precise calculations. Therefore, using inaccurate screen height here for simplifying it.
Geometry gives the height of the whole content view.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this might slow things down though, wdyt?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah overall, it feels like on develop, things load faster and are bit smoother. 🤔