Change advancement form mechanics to match Java behaviour, fix NPE #5396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
onebeastchris
approved these changes
Mar 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the behaviour of the Geyser advancements form a bit. Now, when a
ClientboundSelectAdvancementsTabPacketis received, Geyser stores the specifiedtabId, but only shows the category form when the user is already viewing advancements. If the user is not viewing advancements, then thetabIdis stored, and the user is automatically redirected to the stored category when the user uses/geyser advancements.The same goes for when a user closes and reopens the advancements form - the form will be at the same category as it was when the user closed it, or the root menu form if the user wasn't at any category.
These changes match Java behaviour, and should also resolve a NPE described in #5394 (when
tabIdis null), which this PR should fully resolve.