Don't cancel Microsoft auth flow on Bedrock disconnect#6326
Open
auvq wants to merge 1 commit intoGeyserMC:masterfrom
Open
Don't cancel Microsoft auth flow on Bedrock disconnect#6326auvq wants to merge 1 commit intoGeyserMC:masterfrom
auvq wants to merge 1 commit intoGeyserMC:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6319.
Cancelling the auth future on disconnect defeats the purpose of PendingMicrosoftAuthentication, it's meant to survive disconnects so mobile users can switch to the browser to finish auth. resetRunningFlow was resetTimer (no-op) before the MinecraftAuth port, call site was never updated to match the new semantic. Task cleanup still happens via the configured timeout.
Haven't tested on mobile since I don't have the setup - reasoning is from reading the git blame.
Overall i'm pretty positive it's fixed though