Skip to content

Don't cancel Microsoft auth flow on Bedrock disconnect #6326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
auvq wants to merge 1 commit into
base: master
Choose a base branch
from
+2 −6
Open

Don't cancel Microsoft auth flow on Bedrock disconnect #6326

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions core/src/main/java/org/geysermc/geyser/session/GeyserSession.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1201,12 +1201,8 @@ public void disconnect(Component reason) {

// Remove from session manager
geyser.getSessionManager().removeSession(this);
if (authData != null) {
PendingMicrosoftAuthentication.AuthenticationTask task = geyser.getPendingMicrosoftAuthentication().getTask(authData.xuid());
if (task != null) {
task.resetRunningFlow();
}
}
// Don't cancel any pending Microsoft auth here - the whole point of PendingMicrosoftAuthentication
// is to let mobile users disconnect to finish auth in the browser. Task cleans up on timeout.
}

if (tickThread != null) {
Expand Down
Loading