feat+FIX: enhance VTour component with default tooltip placement and mult…#103
Merged
Merged
Conversation
…i-instance support - Fix major rendering/positioning/etc bugs - Added `defaultPlacement` prop to `VTourProps` for tooltip positioning. - Updated component to use scoped IDs and highlight classes based on the `name` prop. - Improved CSS visibility handling for backdrop and tooltip elements. - Refactored tests to accommodate Teleport rendering and scoped IDs. - Renamed component CSS output to avoid conflicts with SCSS.
Contributor
Author
|
@GlobalHive This fixes major regressions I introduced that broke rendering, behavior. It was a bit of a bear to get it working in parity, but everything is looking good now (testing in local production code repos that use it). |
ChronosMasterOfAllTime
approved these changes
Nov 4, 2025
… in VTour component
Repository owner
deleted a comment from
codecov-commenter
Nov 4, 2025
- Introduced a new test suite for the VTour component focusing on accessibility features. - Verified ARIA attributes, live regions, button labels, and keyboard navigation. - Implemented helper functions for mounting the VTour component with default props. - Updated existing jump options tests to respect accessibility configurations. - Refactored existing tests to utilize new helper functions for improved readability and maintainability. - Added a transition stub to ensure immediate hook execution during tests. - Enhanced timer management in tests to ensure accurate timing and transitions.
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
AdamDrewsTR
changed the title
…rove accessibility support
AdamDrewsTR
changed the title
Contributor
Author
|
@GlobalHive Have time to review this? |
Release-As: 2.5.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enhance VTour component with default tooltip placement and multi-instance support
defaultPlacementprop toVTourPropsfor tooltip positioning.nameprop.Addresses #102
Accessibility