-
Notifications
You must be signed in to change notification settings - Fork 22
chore(cloud-native): sync admin-ui resource scope mapping #2456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: iromli <isman.firmansyah@gmail.com>
📝 WalkthroughWalkthroughVersion pins for JANS and FLEX sources are updated in docker-admin-ui. The docker-flex-all-in-one build workflow is refactored to perform direct cloning and sparse-checkout with explicit WORKDIR management instead of nested /tmp/jans directory operations, with JANS source version also updated. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (5 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Tip 📝 Customizable high-level summaries are now available in beta!You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.
Example instruction:
Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (2)
docker-admin-ui/Dockerfile(2 hunks)docker-flex-all-in-one/Dockerfile(1 hunks)
🧰 Additional context used
🧠 Learnings (1)
📓 Common learnings
Learnt from: devrimyatar
Repo: GluuFederation/flex PR: 2440
File: flex-linux-setup/flex_linux_setup/flex_setup.py:519-519
Timestamp: 2025-11-11T15:17:34.651Z
Learning: In flex-linux-setup/flex_linux_setup/flex_setup.py, the webhook LDIF (aui_webhook.ldif) should only be imported during fresh Admin UI installations, not during updates. The import is correctly guarded by the check `client_check_result['2001.'] == -1` which ensures it only runs when the Admin UI Web Client doesn't already exist. Docker update workflows differ from Linux update workflows in this regard.
🔇 Additional comments (1)
docker-admin-ui/Dockerfile (1)
25-25: Version pins align with PR objectives.The
FLEX_SOURCE_VERSION(line 47) is pinned to7dd724efc02c20c9f22fac0eb90bbf9948202415, which matches the commit containing the resource scope mapping changes referenced in PR #2454. The templates cloned fromFLEX_SETUP_DIR(lines 54–55) will reflect those updates, fulfilling the PR objective to sync resource scope mapping into the OCI image.Also applies to: 47-47



Sync admin-ui resource scope mapping into OCI images.
Closes #2454
Summary by CodeRabbit