Fix #713: rename ControlerHider → ControllerHider

[Suriya-Palaniswami]

Renamed ControlerHider to Controller Hider

Tested this by importing it to Godot 4.3. No output errors and the editor compiles successfully.

XRToolsDesktopControllerHider is compiled as seen in the screenshot.

[BastiaanOlij]

Would need to test if this causes a backwards compatibility issue for project already using this, but I don't think so as the file name doesn't change.

Would be nice if some of the accidental changes could be filtered out (changes to the action map and positioning in the main level scene). But that's probably not that easy so more of a nitpick.

[BastiaanOlij]

I think this is ok but would like a second opinion from @pietru2004

[pietru2004]

I don't see a problem, but please keep in mind that that it should be probably marked in red in changelog or smthg like that since class name changes here.

Also this one will probably only be important to remember for those that use desktop support.

[pietru2004]

also is there difference between controler and controller ?

[Suriya-Palaniswami]

@pietru2004 Sorry, I am new here. Not sure if I should be the one updating the changelog? And to answer your question, there is no difference between controler and controller. It was just misspelled.

[pietru2004]

to be honest @Suriya-Palaniswami IDK should you be updating changelog, I assume the core maintainers will do it before release or smthg like that

[Suriya-Palaniswami]

Makes sense @pietru2004, thanks for clarifying. Considering that checks have passed. I think this is ready to merge. I'll leave this for the maintainers as I don't have permissions. And then subsequently the issue can be closed as well.

[BastiaanOlij]

We try and update the change log on release, but if its added to the PR than that just takes away the effort :)

[BastiaanOlij]

@pietru2004 controller is correct spelling I think, its mainly just that renaming classes does tend to be a breaking change. So it's important to ask if this will be a problem or is acceptable seeing you originally wrote the implementation.

I'm happy to merge this as is.

[pietru2004]

@BastiaanOlij I would say it is an important node, it basicaly hides controlers if desktop mode is active atm, but as long as it is marked in red or as possibly breaking change in changelog I think it should be good.

[BastiaanOlij]

@Suriya-Palaniswami if you don't mind giving this a quick rebase I'll merge it in.

[BastiaanOlij]

I've rebased this into #757 and merged, thanks!