Fix virtual keyboard in the pointer demo#793
Open
AtomicAntt wants to merge 1 commit into
Open
Conversation
Member
|
Hmmm, this makes a lot of sense. I do think this should probably become Sorry for the late response btw, I've been focusing on XRT2. Need to find some time to properly test this and see if we're not missing anything else but this is definately a fix that should be part of the next release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simple change to address #792 where we get the Viewport outside of the SubViewport containing the UI and push input there instead of using:
Input.parse_input_event(input)This fixes the virtual keyboard in the demo, as the demo has a SubViewport when implementing the spectator view which seems to block the input event?
One thing to note is that after this change, I still can't edit the lines in the pointer demo with my desktop keyboard, but the virtual keyboard will work.
Works on Godot 4.4.1 and 4.6.2 in the demo, and on another separate Godot XR project (without spectator view).