Skip to content

Better format and static type World Grab#829

Open
mubinulhaque wants to merge 1 commit into
GodotVR:masterfrom
mubinulhaque:world_grab_formatting
Open

Better format and static type World Grab#829
mubinulhaque wants to merge 1 commit into
GodotVR:masterfrom
mubinulhaque:world_grab_formatting

Conversation

@mubinulhaque

Copy link
Copy Markdown
Contributor

In accordance with style guide given here:

  • Remove space between variable names and colons whenever types must be specified
  • Remove types whenever inferring is possible
  • Add return type to two functions
  • Reorder functions in accordance with the style guide above
  • Format multiline statements for better readability
  • Clarify comments of variables and methods
  • Replace exclamation marks with not keyword
  • Add BBCode to class doc
  • Replace connect(signal, Callable) with signal.connect(Callable)

Testing

The World Grab demo had no issues not present in master. master currently has a bug where the world scale remains changed even after returning to the main menu.

Disclaimer

No generative AI was used to enhance or create the code given here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant