test: add spark4 test to presubmit - #118
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request merges the presubmit-spark4 block into the presubmit block in .kokoro/build.sh. A critical issue was identified where resetting RETURN_CODE to 0 in the merged block discards the exit status of preceding tests, which could cause test failures to be ignored.
|
|
||
| # This job runs on the java17 image; Spark 4.0 needs the JPMS --add-opens flags. |
There was a problem hiding this comment.
Merging the presubmit-spark4 block into presubmit introduces a critical bug: on line 307, RETURN_CODE is reset to 0 (RETURN_CODE=0). This discards the exit status of all the preceding Spark 3.x tests (lines 291-303), meaning any failures in those tests will be ignored and the presubmit job will incorrectly report success. Please remove the RETURN_CODE=0 statement on line 307 so that failures from all tests are properly accumulated.
1 participant
No description provided.