Skip to content

test: add spark4 test to presubmit #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mutianf wants to merge 1 commit into from
Closed

test: add spark4 test to presubmit #118

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .kokoro/build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,8 +301,7 @@ presubmit)
RETURN_CODE=$(($RETURN_CODE || $?))
run_unit_tests "2.13"
RETURN_CODE=$(($RETURN_CODE || $?))
;;
presubmit-spark4)

# This job runs on the java17 image; Spark 4.0 needs the JPMS --add-opens flags.
Comment on lines +304 to 305

@gemini-code-assist gemini-code-assist Bot Aug 3, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Merging the presubmit-spark4 block into presubmit introduces a critical bug: on line 307, RETURN_CODE is reset to 0 (RETURN_CODE=0). This discards the exit status of all the preceding Spark 3.x tests (lines 291-303), meaning any failures in those tests will be ignored and the presubmit job will incorrectly report success. Please remove the RETURN_CODE=0 statement on line 307 so that failures from all tests are properly accumulated.

set_spark4_java_tool_options
RETURN_CODE=0
Expand Down