Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate SecureSourceManager repository fields into input and observed structs #3752

Open
wants to merge 17 commits into
base: master
Choose a base branch
from

Conversation

ericpang777
Copy link
Contributor

@ericpang777 ericpang777 commented Feb 21, 2025

Change description

Fixes #

Tests you have done

  • Run make ready-pr to ensure this PR is ready for review.
  • Perform necessary E2E testing for changed resources.

Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign cheftako for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ericpang777
Copy link
Contributor Author

ericpang777 commented Feb 21, 2025

@gemmahou Branched off #3746

@gemmahou
Copy link
Collaborator

gemmahou commented Feb 21, 2025

Looks good. Pending updates on roundtrip_test.go and _http.log

@ericpang777
Copy link
Contributor Author

ericpang777 commented Feb 21, 2025

Looks good. Pending updates on roundtrip_test.go and _http.log

Done, I also removed the empty URI struct, and added CreateTime. UpdateTime remains semi-commented out because I don't think we even output it. But I guess I can add it to the schema?

@gemmahou
Copy link
Collaborator

Looks good. Pending updates on roundtrip_test.go and _http.log

Done, I also removed the empty URI struct, and added CreateTime. UpdateTime remains semi-commented out because I don't think we even output it. But I guess I can add it to the schema?

No harm to add it now if we plan to output the value in the future.

@ericpang777
Copy link
Contributor Author

Looks good. Pending updates on roundtrip_test.go and _http.log

Done, I also removed the empty URI struct, and added CreateTime. UpdateTime remains semi-commented out because I don't think we even output it. But I guess I can add it to the schema?

No harm to add it now if we plan to output the value in the future.

Added back. I'll leave it out of the mock still to reflect real behaviour.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants