-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate SecureSourceManager repository fields into input and observed structs #3752
base: master
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
09bb943
to
8ed47fc
Compare
Looks good. Pending updates on roundtrip_test.go and _http.log |
b226c20
to
c98ee00
Compare
Done, I also removed the empty URI struct, and added CreateTime. UpdateTime remains semi-commented out because I don't think we even output it. But I guess I can add it to the schema? |
No harm to add it now if we plan to output the value in the future. |
Added back. I'll leave it out of the mock still to reflect real behaviour. |
10382bc
to
a91173e
Compare
Change description
Fixes #
Tests you have done
make ready-pr
to ensure this PR is ready for review.