Skip to content

tests: add golden tests for operator #4528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 22, 2025
Merged

tests: add golden tests for operator #4528

merged 2 commits into from
May 22, 2025

Conversation

@justinsb
Copy link
Collaborator

@justinsb justinsb commented May 13, 2025 •
edited
Loading

  • Simple golden tests

  • tests: add tests for CCC operator

@justinsb justinsb changed the title operator golden tests: add golden tests for operator May 13, 2025
@justinsb
Copy link
Collaborator Author

This likely needs a PR to land in kdp first, but I'm splitting out the experiments feature that motivates this from the introduction of golden tests here.

I'll revise to not include all the CRDs, it just seems pointless....

@justinsb justinsb force-pushed the operator_golden branch 2 times, most recently from 7e6304c to 27afeb1 Compare May 13, 2025 12:34
@justinsb justinsb mentioned this pull request May 15, 2025
Merged
2 tasks
@justinsb justinsb force-pushed the operator_golden branch 2 times, most recently from 80e163c to 1e38271 Compare May 15, 2025 14:36
@jingyih
Copy link
Collaborator

jingyih commented May 15, 2025

/assign @gemmahou

@justinsb
Copy link
Collaborator Author

PR has landed in kdp so this should now hopefully start passing

@gemmahou
Copy link
Collaborator

gemmahou commented May 19, 2025 •
edited
Loading

/lgtm

Seems the main test and comparison logic locate in kubernetes-sigs/kubebuilder-declarative-pattern#418, and we apply it to capture golden logs of operator in this PR. I'm good with the test case, are we going to make this a part of presubmit?

@google-oss-prow google-oss-prow bot added the lgtm label May 19, 2025
@gemmahou
Copy link
Collaborator

/assign @cheftako
Please take a look and help approve this PR, thanks!

@cheftako
Copy link
Collaborator

/lgtm
/approve

@google-oss-prow
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheftako

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit f838ca5 into GoogleCloudPlatform:master May 22, 2025
34 checks passed
@xiaoweim xiaoweim mentioned this pull request Jun 3, 2025
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@cheftako cheftako

@gemmahou gemmahou

Labels

approved lgtm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@justinsb @jingyih @gemmahou @cheftako