Implemented functions to copy a domain store data to the other worker with SharedArrayBuffer#757
Draft
kyasbal wants to merge 2 commits into
Draft
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the domain stores (InternPoolStore, LogStore, and TimelineStore) to use SharedArrayBuffer (with ArrayBuffer fallback) for efficient shared memory structures, enabling transferability to WebWorkers. It configures COOP and COEP headers in Angular and Karma to support this, updates store instantiations to use static factory methods, and adds comprehensive tests. The review feedback suggests optimizing data sharing in TimelineStore by retaining timelineRevisionIds and timelineEventIds as Uint32Array arrays instead of converting them to standard arrays, thereby avoiding unnecessary allocations and serialization overhead.
1747911 to
7da857d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces several methods on domain stores. Methods like
getSharedDataimplemented each domain store creates transferable object from the store and implemented another contructor to initialize stores from the shared data.These changes are base of up coming WebWorker based search approach.