fix: handle mixed text and function call responses in shim #437
+6
−2
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -913,8 +913,12 @@ func candidateToShimCandidate(iterator gollm.ChatResponseIterator) (gollm.ChatRe | |||||
| if text, ok := part.AsText(); ok { | ||||||
| buffer += text | ||||||
| klog.Infof("text is %q", text) | ||||||
| } else if calls, ok := part.AsFunctionCalls(); ok && len(calls) > 0 { | ||||||
| // If we encounter function calls, we should not use the shim | ||||||
| // Instead, pass through the original response | ||||||
| klog.Infof("Warning: there are non-text parts FunctionCall in the response, returning concatenation of all text parts.") | ||||||
|
There was a problem hiding this comment. Grammar issue: 'FunctionCall' should be 'function calls' for better readability.
Suggested change
|
||||||
| // Return the original response without shim conversion | ||||||
| yield(response, nil) | ||||||
|
Member
There was a problem hiding this comment. If I understand correctly, There was a problem hiding this comment. The accumulated text buffer is discarded when function calls are detected. Consider whether any accumulated text should be preserved or if this is the intended behavior. |
||||||
| return | ||||||
| } | ||||||
| } | ||||||
|
|
||||||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The log message is misleading. It states 'returning concatenation of all text parts' but the code actually returns the original response without concatenation.