Handle mixed text + function_call; execute tool calls reliably#536
Open
cnaples79 wants to merge 1 commit intoGoogleCloudPlatform:mainfrom
Open
Handle mixed text + function_call; execute tool calls reliably#536cnaples79 wants to merge 1 commit intoGoogleCloudPlatform:mainfrom
cnaples79 wants to merge 1 commit intoGoogleCloudPlatform:mainfrom
Conversation
…gate parts across all candidates during streaming so function calls are not missed when models return mixed content or tool calls in non-primary candidates.\n\nFixes GoogleCloudPlatform#427
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Execute tool calls even when a model response includes both text and function_call parts, or when function calls appear on non-primary candidates.
Problem
In some cases (e.g., Gemini 2.5 Pro), the assistant can return:
oc4 logs ...)But the function call was not executed and the run ended with:
Root Cause
The streaming handler only inspected the first candidate (
response.Candidates()[0]). If a provider returned function calls in another candidate or mixed content, those calls could be missed.Fix
Files Changed
streamedTextandfunctionCalls.Test Plan
functionCallsis populated.Fixes #427