Skip to content

Handle mixed text + function_call; execute tool calls reliably #536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cnaples79 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Handle mixed text + function_call; execute tool calls reliably #536

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 13 additions & 13 deletions pkg/agent/conversation.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -519,22 +519,22 @@ func (c *Agent) Run(ctx context.Context, initialQuery string) error {
break
}

candidate := response.Candidates()[0]

for _, part := range candidate.Parts() {
// Check if it's a text response
if text, ok := part.AsText(); ok {
log.Info("text response", "text", text)
streamedText += text
}
// Aggregate across all candidates to avoid missing tool calls
for _, candidate := range response.Candidates() {
for _, part := range candidate.Parts() {
// Check if it's a text response
if text, ok := part.AsText(); ok {
log.Info("text response", "text", text)
streamedText += text
}

// Check if it's a function call
if calls, ok := part.AsFunctionCalls(); ok && len(calls) > 0 {
log.Info("function calls", "calls", calls)
functionCalls = append(functionCalls, calls...)
// Check if it's a function call
if calls, ok := part.AsFunctionCalls(); ok && len(calls) > 0 {
log.Info("function calls", "calls", calls)
functionCalls = append(functionCalls, calls...)
}
}
}
}
if llmError != nil {
log.Error(llmError, "error streaming LLM response")
c.setAgentState(api.AgentStateDone)
Expand Down