Add boringcrypto support #415
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jefferbrecht
reviewed
Sep 8, 2025
jefferbrecht
reviewed
Sep 8, 2025
jefferbrecht
reviewed
Sep 8, 2025
jefferbrecht
approved these changes
Sep 16, 2025
Contributor
Author
|
Closing in favour of #419 so I can run the dev build in Kokoro with the new build container. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new distrogen option for
boringcryptowhich will enable the distribution to be built with boringcrypto enabled. This option is now enabled in thegoogle-built-opentelemetry-collectordistribution as well.The alternate build container option has been changed from
ubuntutodebian. I think this is a better base because it is similar to the defaultgocontainer other Go developers may be used to. These changes are more open source distrogen related and don't affect anything internally to Google-Built OpenTelemetry Collector.