-
Notifications
You must be signed in to change notification settings - Fork 38
Add Boringcrypto Support (branch rename) #419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
templates/google-built-opentelemetry-collector/Dockerfile.image_with_gcloud.build.go.tmpl
Outdated
Show resolved
Hide resolved
jefferbrecht
approved these changes
Sep 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the same PR as #415 but I'm renaming the branch to run the build experiment.
This PR adds a new distrogen option for boringcrypto which will enable the distribution to be built with boringcrypto enabled. This option is now enabled in the google-built-opentelemetry-collector distribution as well.
The alternate build container option has been changed from ubuntu to debian. I think this is a better base because it is similar to the default go container other Go developers may be used to. These changes are more open source distrogen related and don't affect anything internally to Google-Built OpenTelemetry Collector.
Testing
Leveraging the
-experiment-workflows, I built a container image from this branch. I pulled the image down on a COS VM and copied the binary out of the container.In that build, I didn't strip the symbols. This was so I could use
go tool nmto verify thatboringcryptois being used:I also ran the container with the same config as smoke tests, and saw the same telemetry get sent all as expected.
This change to using CGO and adding BoringCrypto seems to add about 10 minutes to the container build time. It adds around 3M to the binary size.