Fix issues with expanding variant values #1323
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
douglasjacobsen
force-pushed
the
fix-variant-issues
branch
from
697f3b0 to
c45920c
Compare
linsword13
reviewed
Nov 7, 2025
Member
linsword13
left a comment
linsword13
left a comment
There was a problem hiding this comment.
LGTM, may be worthwhile to add some tests?
douglasjacobsen
force-pushed
the
fix-variant-issues
branch
from
c45920c to
c355e2c
Compare
Collaborator
Author
|
I added a test to cover this behavior. I also cleaned up some dead code. |
douglasjacobsen
force-pushed
the
fix-variant-issues
branch
from
c355e2c to
5c12d55
Compare
douglasjacobsen
force-pushed
the
fix-variant-issues
branch
from
5c12d55 to
61ade0c
Compare
linsword13
approved these changes
Nov 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.