Skip to content
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@
"# Keep Service account and token empty when using the key\n",
"service_account = \"\" # @param {type:\"string\"}\n",
"token = \"\" # @param {type:\"string\"}\n",
"code_whl = \"alphagenome-0.4.2.3-py3-none-any.whl\"\n",
"code_whl = \"alphagenome-0.4.2.5-py3-none-any.whl\"\n",
"file_path = f\"gs://alphagenome-whl/{code_whl}\"\n",
"\n",
"service_account = service_account or None\n",
Expand Down Expand Up @@ -299,7 +299,6 @@
"print(\"Creating HttpDnaClient...\")\n",
"dna_model = dna_client_http.create_http_client(\n",
" vertex_ai_url=vertex_ai_url,\n",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The model_version parameter was removed from the create_http_client call. To enhance code clarity and maintainability, please add a brief inline comment explaining the reason for this removal. This context is crucial for understanding the change, especially if it addresses a deprecation, an invalid default value, or a breaking API change.

    # model_version was removed to resolve a JSON parsing error (e.g., due to deprecation or invalid value).
    vertex_ai_url=vertex_ai_url,

" model_version=\"FOLD_0\",\n",
" service_account=service_account,\n",
" token=token,\n",
")\n",
Expand Down
Loading