Initial changes for Windows compatibility #3824
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djmitche
reviewed
Mar 20, 2025
| #include <windows.h> | ||
| // Windows-specific user info implementation will be needed | ||
| // Create a pwd.h equivalent for Windows | ||
| #else | ||
| #include <pwd.h> |
There was a problem hiding this comment.
This, and unistd.h, appears to be unused and could just be removed.
| // Define uuid_t for Windows compatibility | ||
| typedef UUID uuid_t; | ||
| #ifndef uuid_unparse_lower | ||
| void uuid_unparse_lower(uuid_t uu, char* out); |
There was a problem hiding this comment.
This shouldn't be necessary if HAVE_UUID_UNPARSE_LOWER is unset correctly.
|
@Foadsf will you be able to continue this work? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Windows Compatibility: Initial Changes
This PR introduces initial changes to make Taskwarrior build on Windows with MSVC:
Changes made:
Next steps (not part of this PR):
This is the first step toward making Taskwarrior truly cross-platform and compiler-agnostic. These changes do not affect functionality on Unix/Linux platforms.