-
-
Notifications
You must be signed in to change notification settings - Fork 343
Initial changes for Windows compatibility #3824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Foadsf
wants to merge
3
commits into
GothenburgBitFactory:develop
Choose a base branch
from
Foadsf:develop
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,14 +3,23 @@ message ("-- System: ${CMAKE_SYSTEM_NAME}") | |
|
||
include (CheckCXXCompilerFlag) | ||
|
||
CHECK_CXX_COMPILER_FLAG("-std=c++17" _HAS_CXX17) | ||
# Check for MSVC compiler to use the correct flag | ||
if(MSVC) | ||
set(_HAS_CXX17 ON) # MSVC 2019 supports C++17 by default | ||
set(CMAKE_CXX_STANDARD 17) | ||
set(CMAKE_CXX_STANDARD_REQUIRED ON) | ||
set(CMAKE_CXX_EXTENSIONS OFF) | ||
else() | ||
# For GCC, Clang, etc. | ||
CHECK_CXX_COMPILER_FLAG("-std=c++17" _HAS_CXX17) | ||
|
||
if (_HAS_CXX17) | ||
set (CMAKE_CXX_STANDARD 17) | ||
set (CMAKE_CXX_EXTENSIONS OFF) | ||
else (_HAS_CXX17) | ||
message (FATAL_ERROR "C++17 support missing. Try upgrading your C++ compiler. If you have a good reason for using an outdated compiler, please let us know at [email protected].") | ||
endif (_HAS_CXX17) | ||
if (_HAS_CXX17) | ||
set (CMAKE_CXX_STANDARD 17) | ||
set (CMAKE_CXX_EXTENSIONS OFF) | ||
else (_HAS_CXX17) | ||
message (FATAL_ERROR "C++17 support missing. Try upgrading your C++ compiler. If you have a good reason for using an outdated compiler, please let us know at [email protected].") | ||
endif (_HAS_CXX17) | ||
endif() | ||
|
||
if (${CMAKE_SYSTEM_NAME} MATCHES "Linux") | ||
set (LINUX true) | ||
|
@@ -34,9 +43,15 @@ elseif (${CMAKE_SYSTEM_NAME} STREQUAL "GNU") | |
elseif (${CMAKE_SYSTEM_NAME} STREQUAL "CYGWIN") | ||
set (CYGWIN true) | ||
set (CMAKE_CXX_EXTENSIONS ON) | ||
else (${CMAKE_SYSTEM_NAME} MATCHES "Linux") | ||
elseif (${CMAKE_SYSTEM_NAME} MATCHES "Windows") | ||
set (WINDOWS true) | ||
# Add Windows-specific flags if needed | ||
else () | ||
set (UNKNOWN true) | ||
endif (${CMAKE_SYSTEM_NAME} MATCHES "Linux") | ||
endif () | ||
|
||
set (CMAKE_CXX_FLAGS "${_CXX14_FLAGS} ${CMAKE_CXX_FLAGS}") | ||
set (CMAKE_CXX_FLAGS "-Wall -Wextra -Wsign-compare -Wreturn-type ${CMAKE_CXX_FLAGS}") | ||
if(NOT MSVC) | ||
# These flags are not applicable to MSVC | ||
set (CMAKE_CXX_FLAGS "${_CXX14_FLAGS} ${CMAKE_CXX_FLAGS}") | ||
set (CMAKE_CXX_FLAGS "-Wall -Wextra -Wsign-compare -Wreturn-type ${CMAKE_CXX_FLAGS}") | ||
endif() |
Submodule libshared
updated
from 2aa844 to 1e949b
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -30,16 +30,25 @@ | |
#include <cmake.h> | ||
// cmake.h include header must come first | ||
|
||
#include <sys/types.h> | ||
|
||
#include <string> | ||
#include <vector> | ||
#if defined(FREEBSD) || defined(OPENBSD) | ||
|
||
// Platform-specific UUID handling | ||
#ifdef _WIN32 | ||
#include <rpc.h> | ||
#include <windows.h> | ||
// Define uuid_t for Windows compatibility | ||
typedef UUID uuid_t; | ||
#ifndef uuid_unparse_lower | ||
void uuid_unparse_lower(uuid_t uu, char* out); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This shouldn't be necessary if HAVE_UUID_UNPARSE_LOWER is unset correctly. |
||
#endif | ||
#elif defined(FREEBSD) || defined(OPENBSD) | ||
#include <sys/types.h> | ||
#include <uuid.h> | ||
#else | ||
#include <sys/types.h> | ||
#include <uuid/uuid.h> | ||
#endif | ||
#include <Table.h> | ||
|
||
// util.cpp | ||
int confirm4(const std::string&); | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This, and unistd.h, appears to be unused and could just be removed.