Skip to content

Conversation

@muhAzri
Copy link
Contributor

@muhAzri muhAzri commented May 3, 2025

Fix profile fields width by adding modifier support to BorderedTextField

Thank you for opening a Pull Request!
Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open a GitHub issue as a bug/feature request before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests are added/updated (if necessary)
  • Ensure the linter passes (./codeAnalysis to automatically apply formatting/linting)
  • Appropriate docs were updated (if necessary)

Description

This PR fixes an issue where the profile fields in the ProfileScreen weren't filling the maximum width of the screen, leaving unused space on the right side. The root cause was that the BorderedTextField component didn't accept a modifier parameter, preventing it from receiving layout directives from its parent components.

Changes

  • Added a modifier parameter to the BorderedTextField component
  • Applied the modifier to the Box wrapper in BorderedTextField
  • Updated ProfileField to pass Modifier.fillMaxWidth() to BorderedTextField
  • Removed redundant padding application in BorderedTextField for cleaner code

Visual Changes

Before: Profile fields didn't utilize the full width of the screen, leaving empty space on the right
image

After: Profile fields now properly extend to fill the entire width of the screen
image

Fixes #1138 🦕

muhAzri added 2 commits May 3, 2025 12:50
- Added modifier parameter to BorderedTextField component
- Updated ProfileField to pass fillMaxWidth() modifier
- Cleaned up redundant padding application in BorderedTextField
- Resolves issue where profile fields didn't utilize full screen width
@EngrTaofeek
Copy link
Collaborator

@muhAzri thanks for this looks like great progress just one tiny detail left. The green underline does not extend to the end as shown I the screenshot below.
Screenshot_1746472161
just that

@EngrTaofeek
Copy link
Collaborator

Hi @muhAzri ,

To ensure you have everything you need to run the application smoothly, I'd like to share the tree_tracker.keys.properties file with you. Please join the Greenstand Slack community, and I'll send it to you there. This will eliminate the need to comment/uncomment lines in your configuration.

Also, to keep our workflow organized, I recommend creating a new branch for each feature, task, or pull request (PR) instead of working directly on the master branch of your fork. This practice helps maintain a clean and manageable version history.

Thanks

@muhAzri
Copy link
Contributor Author

muhAzri commented May 6, 2025

Hi @EngrTaofeek
Thanks a lot for the feedback!

✅ I've fixed the reported issues the green underline not extending fully — it should now match the expected result.

🙏 Noted on the suggestion to use a separate branch for future PRs. I’ll definitely follow that practice going forward to keep things more organized.

Looking forward to your review!
Thanks

@EngrTaofeek EngrTaofeek merged commit 4aeccbe into Greenstand:master May 6, 2025
1 check passed
@EngrTaofeek
Copy link
Collaborator

Looks good. Thank you for your contribution I have merged it in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bordered TextField bug

2 participants