Fix issues with MSVC and OneAPI CI due to VS 18 2026#6438
Fix issues with MSVC and OneAPI CI due to VS 18 2026#6438jhendersonHDF wants to merge 4 commits into
Conversation
jhendersonHDF
added
the
Component - Testing
Review ChecklistThis PR touches the following areas. Each needs at least one
|
|
|
||
| Intel_oneapi_windows: | ||
| name: "windows-oneapi ${{ inputs.build_mode }}" | ||
| runs-on: windows-latest |
There was a problem hiding this comment.
The fortran-lang/setup-fortran action that's currently being used to setup OneAPI hasn't been updated yet for the latest windows, so this can only run on windows-2025 and not windows-latest (depending on where windows-latest gets mapped to, either windows-2025 or windows-2025-vs2026).
There was a problem hiding this comment.
Correction, windows-2022 is needed currently until the OneAPI setup can be updated
jhendersonHDF
force-pushed
the
update_vs_version
branch
2 times, most recently
from
cd4bf69 to
d3b125e
Compare
jhendersonHDF
force-pushed
the
update_vs_version
branch
from
d3b125e to
6e354de
Compare
jhendersonHDF
force-pushed
the
update_vs_version
branch
from
6e354de to
0aa3d52
Compare
| force_java_implementation: "jni" | ||
| java_version: 11 | ||
| win_runner: "windows-2022" | ||
| win_vs_generator: "Visual Studio 17 2022" |
There was a problem hiding this comment.
CMake 3.26 doesn't support VS 18 2026, so this action has to use windows-2022 with VS 17 2022
| - name: Setup Java | ||
| uses: actions/setup-java@be666c2fcd27ec809703dec50e508c2fdc7f6654 # v5.2.0 | ||
| with: | ||
| java-version: 11 |
There was a problem hiding this comment.
windows-2022 uses Java 8 by default whereas windows-latest uses 17. Since Java 11 is the minimum required, that has to be specified for windows-2022 runs
jhendersonHDF
changed the title
2 participants
Visual Studio 17 2022 seems to no longer be available from actions run on windows-latest from forks
Ref: actions/runner-images#14017