Skip to content

Recover low state source timestamps - #2764

Merged
schmidma merged 4 commits into
HULKs:mainfrom
schmidma:low-state-timestamp-match
Jul 4, 2026
Merged

Recover low state source timestamps#2764
schmidma merged 4 commits into
HULKs:mainfrom
schmidma:low-state-timestamp-match

Conversation

@schmidma

@schmidma schmidma commented Jul 3, 2026

Copy link
Copy Markdown
Member

Summary

  • recover /low_state source times by matching low-state motor values to /joint_states
  • publish low-state-derived ROS-Z topics with the matched vendor timestamp
  • allow joint_states through the K1 Zenoh DDS bridge config

Motivation

/low_state has no embedded timestamp, so the bridge previously tagged it with receive/republish time. Matching to /joint_states.header.stamp removes receive-path jitter for IMU and motor-state consumers.

Implementation

  • add Publisher::publish_with_source_time
  • add ros2::sensor_msgs::joint_state::JointState
  • buffer recent low-state and joint-state samples in low_state_bridge
  • match exact f32 bit keys for position, velocity, and effort/torque
  • drop stale or non-monotonic matches instead of publishing guessed timestamps

Verification

  • cargo nextest run -p ros-z -p low_state_bridge
  • cargo build -p ros2 -p low_state_bridge -p hulk_ros_z
  • cargo fmt --check

@schmidma schmidma self-assigned this Jul 3, 2026
@github-project-automation github-project-automation Bot moved this to In Progress in Development Jul 3, 2026
@schmidma
schmidma force-pushed the low-state-timestamp-match branch from 6905bc8 to 5589cf6 Compare July 3, 2026 23:47
@schmidma
schmidma force-pushed the low-state-timestamp-match branch from 5589cf6 to 7725f38 Compare July 4, 2026 00:38
@schmidma
schmidma marked this pull request as ready for review July 4, 2026 02:09
@schmidma schmidma moved this from In Progress to (hidden) in Development Jul 4, 2026
@schmidma schmidma moved this from (hidden) to Review in Development Jul 4, 2026
@schmidma schmidma removed their assignment Jul 4, 2026
@schmidma
schmidma enabled auto-merge July 4, 2026 02:10
Comment thread docs/setup/upload.md Outdated

@alexschmander alexschmander left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@schmidma
schmidma added this pull request to the merge queue Jul 4, 2026
Merged via the queue into HULKs:main with commit e9e3981 Jul 4, 2026
6 checks passed
@schmidma
schmidma deleted the low-state-timestamp-match branch July 4, 2026 10:48
@github-project-automation github-project-automation Bot moved this from Review to Done in Development Jul 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants